[libvirt PATCH 1/6] slirp: leave the dbus daemon running on error

[Michal Privoznik]

On 4/8/20 7:23 PM, marcandre.lureau at redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau at redhat.com>
> 
> Don't stop the DBus daemon if a slirp helper failed to start, as it
> may be shared with other helpers.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> ---
>   src/qemu/qemu_slirp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_slirp.c b/src/qemu/qemu_slirp.c
> index 09c1247892..49bffa01b8 100644
> --- a/src/qemu/qemu_slirp.c
> +++ b/src/qemu/qemu_slirp.c
> @@ -355,6 +355,6 @@ qemuSlirpStart(qemuSlirpPtr slirp,
>           virProcessKillPainfully(pid, true);
>       if (pidfile)
>           unlink(pidfile);
> -    qemuDBusStop(driver, vm);
> +    /* leave dbus daemon running, it may be used by others */
>       return -1;
>   }
> 

I'm not quite sure about this one. Who do you mean by "others"? Other 
interfaces? Is this supposed to help with 3/6 so that if we attempt to 
double start the dbus daemon the second attempt doesn't actually kill 
the daemon started in the first attempt?

ACK to the rest.

Michal