[PATCH RESEND v1 0/7] add Spectre related PowerPC features

[Michal Privoznik]

On 4/27/20 2:14 PM, Daniel Henrique Barboza wrote:
> Recent changes in master (adding aio_io_uring cap, splitting
> feature parsing code to a new function, updates in news.xml)
> broke rebase for all patches in the series. Re-sending it, rebased
> with master at 606fb3979ab4.
> 
> ****
> 
> Hi,
> 
> This series implements 3 Spectre related PowerPC features that
> were added back in QEMU 2.12:
> 
> - CFPC: Cache Flush on Privilege Change
> - SBBC: Speculation Barrier Bounds Checking
> - IBS:  Indirect Branch Speculation
> 
> These options aren't much of a problem for users using latest
> hardware and guests with recent Linux kernels. Users with outdated
> hardware/firmware or trying to run AIX guests/guests with older
> kernels, however, will need to fine tune these options because
> QEMU defaults won't work.
> 
> Instead of making users rely on <qemu:commandline> elements to
> hardcode the options in the XML, let's support them in Libvirt.
> 
> 
> 
> Daniel Henrique Barboza (7):
>    qemu: Add capability for CFPC pSeries feature
>    qemu: Implement the CFPC pSeries feature
>    qemu: Add capability for SBBC pSeries feature
>    qemu: Implement the SBBC pSeries feature
>    qemu: Add capability for IBS pSeries feature
>    qemu: Implement the IBS pSeries feature
>    news: Update for the recent added pSeries features
> 
>   docs/formatdomain.html.in                     |  36 +++++
>   docs/news.xml                                 |  10 ++
>   docs/schemas/domaincommon.rng                 |  47 ++++++
>   src/conf/domain_conf.c                        | 134 ++++++++++++++++++
>   src/conf/domain_conf.h                        |  38 +++++
>   src/libvirt_private.syms                      |   3 +
>   src/qemu/qemu_capabilities.c                  |   8 ++
>   src/qemu/qemu_capabilities.h                  |   5 +
>   src/qemu/qemu_command.c                       |  15 ++
>   src/qemu/qemu_validate.c                      |  33 +++++
>   .../caps_2.12.0.ppc64.xml                     |   3 +
>   .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml |   3 +
>   .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml |   3 +
>   .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml |   3 +
>   .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |   3 +
>   .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |   3 +
>   tests/qemuxml2argvdata/pseries-features.args  |   3 +-
>   tests/qemuxml2argvdata/pseries-features.xml   |   3 +
>   tests/qemuxml2argvtest.c                      |  53 ++++++-
>   tests/qemuxml2xmloutdata/pseries-features.xml |   3 +
>   tests/qemuxml2xmltest.c                       |   5 +-
>   21 files changed, 411 insertions(+), 3 deletions(-)
> 

I've fixed all three TypeFromString()/TypeToString() places, and pushed.

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal