[libvirt-dbus PATCH 9/9] spec: Pick documentation from installation directory

Andrea Bolognani abologna at redhat.com
Mon Apr 27 12:51:52 UTC 2020


On Mon, 2020-04-27 at 14:39 +0200, Pavel Hrdina wrote:
> On Sat, Apr 25, 2020 at 10:59:46PM +0200, Andrea Bolognani wrote:
> >  %files
> > -%doc AUTHORS.rst NEWS.rst
> > -%license COPYING
> > +%doc %{_docdir}/%{name}/AUTHORS.rst
> > +%doc %{_docdir}/%{name}/NEWS.rst
> > +%license %{_docdir}/%{name}/COPYING
> 
> This patch will change the location of COPYING file from
> 
>     /usr/share/licenses/libvirt-dbus/COPYING
> 
> to
> 
>     /usr/share/doc/libvirt-dbus/COPYING
> 
> Which is probably OK but the preferred location is the licenses
> directory.  I would like to keep this behavior for RPM packages
> which means move the file in the %install phase or using this:
> 
> %exclude %{_docdir}/%{name}/COPYING
> %license COPYING

That's a nuance of RPM packaging that I completely missed.

I'll squash in the %exclude trick you suggest and verify that the
file actually ends up in the expected location before pushing.

Thanks for the speedy review! :)

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list