[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt PATCH 6/8] virsh: completer: use signed variable for XPathNodeSet errors



Although virXPathNodeSet is unlikely to return -1, we should
check for it properly or not at all.

Signed-off-by: Ján Tomko <jtomko redhat com>
---
 tools/virsh-completer-host.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/virsh-completer-host.c b/tools/virsh-completer-host.c
index 35e6bba661..8893888ec2 100644
--- a/tools/virsh-completer-host.c
+++ b/tools/virsh-completer-host.c
@@ -55,7 +55,7 @@ virshAllocpagesPagesizeCompleter(vshControl *ctl,
 {
     g_autoptr(xmlXPathContext) ctxt = NULL;
     virshControlPtr priv = ctl->privData;
-    unsigned int npages = 0;
+    int npages = 0;
     g_autofree xmlNodePtr *pages = NULL;
     g_autoptr(xmlDoc) doc = NULL;
     size_t i = 0;
@@ -106,7 +106,7 @@ virshCellnoCompleter(vshControl *ctl,
 {
     g_autoptr(xmlXPathContext) ctxt = NULL;
     virshControlPtr priv = ctl->privData;
-    unsigned int ncells = 0;
+    int ncells = 0;
     g_autofree xmlNodePtr *cells = NULL;
     g_autoptr(xmlDoc) doc = NULL;
     size_t i = 0;
-- 
2.26.2


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]