[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt PATCH 037/351] meson: add readline build option



On Wed, 2020-08-05 at 13:27 +0200, Pavel Hrdina wrote:
> Gross hack in our CI vs gross hack in spec file. I vote for CI to have
> the hack.
> 
> In addition the macros are provided by meson and there are changes in
> the macro file, for example the latest macro file uses `meson compile`
> instead of `ninja build` which was introduced in 0.54.0 so we would have
> to have some older copy of the macros.

Not really, since the version of Meson that we use for building would
still be the one installed from PyPi, eg. 0.54.0 or newer. What about
the other way around? Would the old macros work fine with the newer
Meson?

> We could probably come up with some replacement for the macro that would
> work on all OSes that lack the correct meson version but I don't think
> it's better then having it solved in our CI.

Note that this doesn't only affect our CI but also anyone who wants
to build the RPM on CentOS. Telling those users "install Meson from
PyPi" sounds more reasonable than "install Meson from PyPi and also
from RPM".

> And the fact that our spec file is already large is not a solid argument
> to add some ugly workaround there. If anything we should clean it up.

Fair enough :)

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]