[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt PATCH 2/3] test: fix emulator pin info in test driver



On Fri, Aug 07, 2020 at 04:59:13PM +0200, Pavel Hrdina wrote:
> Commit <6328da04285d9f65cb323d399f731c20caf63f5a> introduced
> testDomainGetEmulatorPinInfo() into test driver but used
> virHostCPUGetCount() function to get the number of host CPUs.
> 
> This would be correct for other drivers but in test driver we must not
> depend on the host, we have to use hard-coded host representation that
> we have in test driver.
> 
> Follows the logic of testDomainGetVcpuPinInfo().
> 
> Signed-off-by: Pavel Hrdina <phrdina redhat com>
> ---
>  src/test/test_driver.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange redhat com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]