[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] meson: fix some FreeBSD checks regressions



On Sat, Aug 08, 2020 at 01:22:09PM +0400, Roman Bogorodskiy wrote:
>  * Add missing prerequisite headers for checking link_addr(3)
>    in net/if_dl.h,
>  * Add missing prerequisite headers for checking BRDGSFD, BRDGADD,
>    BRDGDEL in net/if_bridgevar.h,
>  * When checking for ifconfig(8), set not only IFCONFIG value,
>    but also IFCONFIG_PATH as it's used in util/virnetdevip.c.
> 
> Signed-off-by: Roman Bogorodskiy <bogorodskiy gmail com>
> ---
>  meson.build | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)

It would be probably better to split this into 3 patches as it fixes
three different issues but it's good enough.

<rant>
I really hate a lot the fact that in order to use some headers you have
to include some other headers. It's so annoying and ridiculous.
</rant>

Thanks for addressing these regressions!

Reviewed-by: Pavel Hrdina <phrdina redhat com>

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]