[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [GSoC][PATCH 2/7] qemu_domainjob: added maxQueuedJobs and jobs_queued to `qemuDomainJob`



On Tue, Aug 04, 2020 at 08:06:44PM +0530, Prathamesh Chavan wrote:
> Since the attribute `jobs_queued` was specific to jobs,
> we decided to move this from `qemuDomainObjPrivate`
> to `qemuDomainJobObj` structure.
>
> Also, reference to `maxQueuedJobs` required us to access
> config of the qemu-driver. And creating its copy in
> the `qemuDomainJob` helped us access the variable
> without referencing the driver's config.

Just like you split the paragraphs in the commit message, this patch should
have been split in 2 as well even though both changes lead to a common goal.

Erik


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]