[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] meson: fix some FreeBSD checks regressions



  Pavel Hrdina wrote:

> On Sat, Aug 08, 2020 at 01:22:09PM +0400, Roman Bogorodskiy wrote:
> >  * Add missing prerequisite headers for checking link_addr(3)
> >    in net/if_dl.h,
> >  * Add missing prerequisite headers for checking BRDGSFD, BRDGADD,
> >    BRDGDEL in net/if_bridgevar.h,
> >  * When checking for ifconfig(8), set not only IFCONFIG value,
> >    but also IFCONFIG_PATH as it's used in util/virnetdevip.c.
> > 
> > Signed-off-by: Roman Bogorodskiy <bogorodskiy gmail com>
> > ---
> >  meson.build | 14 +++++++++-----
> >  1 file changed, 9 insertions(+), 5 deletions(-)
> 
> It would be probably better to split this into 3 patches as it fixes
> three different issues but it's good enough.

Thanks for the reviews, pushed as 3 separate patches.

> <rant>
> I really hate a lot the fact that in order to use some headers you have
> to include some other headers. It's so annoying and ridiculous.
> </rant>

Indeed.
It's also frustrating that there's no way (I guess) to differentiate
cases when the symbol is not present, or there's an error in the check
itself.

> 
> Thanks for addressing these regressions!
> 
> Reviewed-by: Pavel Hrdina <phrdina redhat com>



Roman Bogorodskiy

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]