[PATCH v2 08/13] qemu: don't shutdown event thread in monitor EOF callback

[Daniel Henrique Barboza]

On 7/23/20 7:14 AM, Nikolay Shirokovskiy wrote:
> This hunk was introduced in [1] in order to avoid loosing
> events from monitor on stopping qemu process. But as explained
> in [2] on destroy we won't get neither EOF nor any other
> events as monitor is just closed. In case of crash/shutdown
> we won't get any more events as well and qemuDomainObjStopWorker
> will be called by qemuProcessStop eventually. Thus let's
> remove qemuDomainObjStopWorker from qemuProcessHandleMonitorEOF
> as it is not useful anymore.
> 
> [1] e6afacb0f: qemu: start/stop an event loop thread for domains
> [2] d2954c072: qemu: ensure domain event thread is always stopped
> 
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy at virtuozzo.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>

>   src/qemu/qemu_process.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
> index e8b15ee..44098fe 100644
> --- a/src/qemu/qemu_process.c
> +++ b/src/qemu/qemu_process.c
> @@ -322,9 +322,6 @@ qemuProcessHandleMonitorEOF(qemuMonitorPtr mon,
>       qemuDomainDestroyNamespace(driver, vm);
>   
>    cleanup:
> -    /* Now we got EOF we're not expecting more I/O, so we
> -     * can finally kill the event thread */
> -    qemuDomainObjStopWorker(vm);
>       virObjectUnlock(vm);
>   }
>   
>