[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt PATCH v2 1/1] meson: Drop RPATH usage



Right now we're unconditionally adding RPATH information to the
installed binaries and libraries, but that's not always desired.

Debian explicitly passes --disable-rpath to configure, and while
I haven't been able to find the same option in the spec file for
either Fedora or RHEL, by running

  $ readelf -d /usr/bin/virsh | grep PATH

I can see that the information is not present, so I assume they
also strip it somehow.

Both Debian and Fedora have wiki pages encouraging packagers to
avoid setting RPATH:

  https://wiki.debian.org/RpathIssue
  https://fedoraproject.org/wiki/RPath_Packaging_Draft

Given the above, it looks like it's actually better to not go
out of our way to include that information in the first place.

Signed-off-by: Andrea Bolognani <abologna redhat com>
---
 src/meson.build   | 6 ------
 tools/meson.build | 4 ----
 2 files changed, 10 deletions(-)

diff --git a/src/meson.build b/src/meson.build
index 73ac99f01e..84d9ab9741 100644
--- a/src/meson.build
+++ b/src/meson.build
@@ -454,7 +454,6 @@ libvirt_qemu_lib = shared_library(
     libvirt_qemu_syms_file,
   ],
   install: true,
-  install_rpath: libdir,
   version: libvirt_lib_version,
   soversion: libvirt_so_version,
 )
@@ -510,7 +509,6 @@ libvirt_lxc_lib = shared_library(
     libvirt_lxc_syms_file,
   ],
   install: true,
-  install_rpath: libdir,
   version: libvirt_lib_version,
   soversion: libvirt_so_version,
 )
@@ -554,7 +552,6 @@ libvirt_admin_lib = shared_library(
     libvirt_admin_syms_file,
   ],
   install: true,
-  install_rpath: libdir,
   version: libvirt_lib_version,
   soversion: libvirt_so_version,
 )
@@ -588,7 +585,6 @@ foreach module : virt_modules
     ],
     install: true,
     install_dir: module.get('install_dir', libdir / 'libvirt' / 'connection-driver'),
-    install_rpath: libdir,
   )
   set_variable('@0 _module'.format(module['name'].underscorify()), mod)
 endforeach
@@ -633,7 +629,6 @@ foreach daemon : virt_daemons
     ],
     install: true,
     install_dir: sbindir,
-    install_rpath: libdir,
   )
 endforeach
 
@@ -661,7 +656,6 @@ foreach helper : virt_helpers
     ],
     install: true,
     install_dir: helper.get('install_dir', libexecdir),
-    install_rpath: libdir,
   )
 endforeach
 
diff --git a/tools/meson.build b/tools/meson.build
index 090179470a..db6a61bad7 100644
--- a/tools/meson.build
+++ b/tools/meson.build
@@ -75,7 +75,6 @@ if conf.has('WITH_HOST_VALIDATE')
     ],
     install: true,
     install_dir: bindir,
-    install_rpath: libdir,
   )
 endif
 
@@ -112,7 +111,6 @@ if conf.has('WITH_LOGIN_SHELL')
     ],
     install: true,
     install_dir: libexecdir,
-    install_rpath: libdir,
   )
 
   install_data('virt-login-shell.conf', install_dir: sysconfdir / 'libvirt')
@@ -197,7 +195,6 @@ executable(
   ],
   install: true,
   install_dir: bindir,
-  install_rpath: libdir,
 )
 
 executable(
@@ -219,7 +216,6 @@ executable(
   ],
   install: true,
   install_dir: bindir,
-  install_rpath: libdir,
 )
 
 tools_conf = configuration_data()
-- 
2.26.2


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]