[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] tools: fix libvirt-guests.sh text assignments



On Friday, August 21, 2020 10:05:21 AM, Christian Ehrhardt wrote:
> > , and your
> > suggested change would make these assignments work even on shells that do
> > not apply special parsing rules for it.
> 
> Thanks, I also have pushed this through a bunch of tests that use
> libvirt-guests.sh on multiple situations and architectures.
> They all worked fine with the fix (and were the ones spotting the
> issue in the first place).
> So after adding these extra bits of info to the commit message, fixing
> a typo in there and running a gitlab CI pipeline on it I'm pushing the
> commit.

While the patch itself looks good, and it's great that you managed to
track down the issue as well as give the fix some serious testing, it
looks like you ultimately pushed this change without getting a proper
review.

There are situations where pushing changes without review is
warranted, but this doesn't seem to fall into one of those fairly
narrow guidelines.

In the future, please refrain from pushing changes that haven't gone
through the usual review process.

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]