[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] src/meson: add module name_suffix as 'so'



On Sat, Aug 22, 2020 at 6:34 PM Scott Shambarger
<scott-libvirt shambarger net> wrote:
>
> driver.c and locking/lock_manager.c both hardcode ".so" to
> module filenames.  In meson, MacOS bundles (loadable objects)
> default to using ".dylib" - adding name_suffix as "so" will
> therefore align the code with all builds (no need to handle
> windows as it doesn't support libvirtd).
>
> Signed-off-by: Scott Shambarger <scott-libvirt shambarger net>
> ---
>  src/meson.build | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/meson.build b/src/meson.build
> index 73ac99f01e..73986401c9 100644
> --- a/src/meson.build
> +++ b/src/meson.build
> @@ -567,6 +567,7 @@ foreach module : virt_modules
>      module['name'],
>      module.get('sources', []),
>      name_prefix: module.get('name_prefix', 'lib'),
> +    name_suffix: 'so',
>      include_directories: [
>        conf_inc_dir,
>        module.get('include', []),
> --
> 2.24.3 (Apple Git-128)
>

Shouldn't it be fixed the other way? That is, it should know about
DLL, SO, or DYLIB extensions depending on the platform...

Also, libvirtd would probably work on Cygwin or Midipix, which would
use DLL files...



--
真実はいつも一つ!/ Always, there's only one truth!



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]