[libvirt PATCH v3] meson: Improve RPATH handling

Pavel Hrdina phrdina at redhat.com
Mon Aug 24 08:49:15 UTC 2020


On Wed, Aug 19, 2020 at 04:29:31PM +0200, Andrea Bolognani wrote:
> Right now we're unconditionally adding RPATH information to the
> installed binaries and libraries, but that's not always desired.
> 
> autotools seem to be smart enough to only include that information
> when targeting a non-standard prefix, so most distro packages
> don't actually contain it; moreover, both Debian and Fedora have
> wiki pages encouraging packagers to avoid setting RPATH:
> 
>   https://wiki.debian.org/RpathIssue
>   https://fedoraproject.org/wiki/RPath_Packaging_Draft
> 
> Implement RPATH logic that Does The Right Thing™ in the most
> common cases, while still offering users the ability to override
> the default behavior if they have specific needs.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  meson.build       | 10 ++++++++++
>  meson_options.txt |  1 +
>  src/meson.build   | 12 ++++++------
>  tools/meson.build |  8 ++++----
>  4 files changed, 21 insertions(+), 10 deletions(-)

Looks reasonable to not add RPATH when using /usr as prefix.

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200824/f89f5d00/attachment-0001.sig>


More information about the libvir-list mailing list