[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] qemu: Move virQEMUFileOpenAs to qemu_domain.c



On Mon, Aug 24, 2020 at 17:52:00 +0200, Peter Krempa wrote:
> Commit 43620689794507308fbd3def6992a68ee2f8fa97 moved the function to
> util/virqemu.c which is compiled also on win32 and geteuid()/getegid()
> doesn't exist there.
> 
> Move it to qemu_domain.c which is compiled only when the qemu driver is
> enabled. Originally I didn't want to put it here as qemu_domain.c is a
> code dump for helper functions but this is the least invasive fix.
> 
> Signed-off-by: Peter Krempa <pkrempa redhat com>
> ---
>  src/libvirt_private.syms |   1 -
>  src/qemu/qemu_domain.c   | 124 +++++++++++++++++++++++++++++++++++++
>  src/qemu/qemu_domain.h   |   7 +++
>  src/util/virqemu.c       | 130 ---------------------------------------
>  src/util/virqemu.h       |   7 ---
>  5 files changed, 131 insertions(+), 138 deletions(-)

The pipeline succeeded now:

https://gitlab.com/pipo.sk/libvirt/-/pipelines/181389560

I'll be pushing it in a while if nobody objects under the build-breaker
rule.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]