[PATCH 0/5] remove NVDIMM auto-alignment for pSeries guests

Michal Privoznik mprivozn at redhat.com
Mon Aug 24 17:22:49 UTC 2020


On 8/24/20 6:52 PM, Daniel Henrique Barboza wrote:
> 
> 
> On 8/24/20 1:44 PM, Michal Privoznik wrote:
>> On 7/30/20 9:47 PM, Daniel Henrique Barboza wrote:
>>> Hi,
>>>
>>> In [1] Andrea proposed that we should *not* auto-align down
>>> the NVDIMM size for pSeries guests. Instead we should error
>>> out and provide users with a suggested aligned value. This
>>> patch implements it.
>>>
>>> [1] https://www.redhat.com/archives/libvir-list/2020-July/msg01471.html
>>>
>>>
>>> Daniel Henrique Barboza (5):
>>>    qemu_domain.c: make qemuDomainGetMemorySizeAlignment() public
>>>    qemu_validate.c: add pSeries NVDIMM size alignment validation
>>>    qemu_domain.c: do not auto-align ppc64 NVDIMMs
>>>    qemu_domain.c: change qemuDomainMemoryDeviceAlignSize() return type
>>>    Revert "formatdomain.html.in: mention pSeries NVDIMM 'align down'
>>>      mechanic"
>>>
>>>   docs/formatdomain.html.in                     |  6 +-
>>>   src/qemu/qemu_domain.c                        | 57 ++-----------------
>>>   src/qemu/qemu_domain.h                        |  7 ++-
>>>   src/qemu/qemu_hotplug.c                       |  6 +-
>>>   src/qemu/qemu_validate.c                      | 43 ++++++++++++--
>>>   ...ory-hotplug-nvdimm-ppc64.ppc64-latest.args |  2 +-
>>>   .../memory-hotplug-nvdimm-ppc64.xml           |  2 +-
>>>   .../memory-hotplug-nvdimm-ppc64.xml           |  2 +-
>>>   8 files changed, 55 insertions(+), 70 deletions(-)
>>>
>>
>> Reviewed-by: Michal Privoznik <mprivozn at redhat.com>
>>
>> and pushed. Sorry for delay. Do you think this deserves a NEWS.rst entry?
> 
> 
> For 6.7.0? Yeah I think it would be good. Do you want me to post a patch
> updating it? If you're going to update NEWS.rst with other things
> feel free to add this info as well.

Yeah, I plan to write NEWS.rst update tomorrow, but I could use some 
help :-)

Michal




More information about the libvir-list mailing list