[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] src/meson: add module name_suffix as 'so'



On Mon, Aug 24, 2020 at 06:15:57PM -0700, Scott Shambarger wrote:
> On 2020-08-24 02:34, Daniel P. Berrangé wrote:
> > I don't think we want to keep compatibility with any libtool quirks. We
> > should do the right thing for the platform, and I think that means using
> > the platform native suffix for shared library modles correctly.
> > 
> 
> Of course... we'd still have to deal with meson quirks (it suffixes modules
> with .dylib instead of .bundle on MacOS).
> 
> I'm happy to take a crack at a patch using the platform suffix in the
> code... any idea how to configure meson to put the module suffix into
> config.h?  (I'm kinda new to meson - would be easy in autoconf :)

I wouldn't bother - just  #ifdef __APPLE__ in the source code


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]