[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt PATCH v2 16/16] virsh: add "nodedev-start" command



On Tue, Aug 18, 2020 at 09:48:06AM -0500, Jonathon Jongsma wrote:
> This virsh command maps to virNodeDeviceCreate(), which starts a node
> device that has been previously defined by virNodeDeviceDefineXML().
> This is only supported for mediated devices.
>
> Signed-off-by: Jonathon Jongsma <jjongsma redhat com>
> ---
>  tools/virsh-nodedev.c | 61 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 61 insertions(+)
>
> diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c
> index db56fbc5e9..eea576ff89 100644
> --- a/tools/virsh-nodedev.c
> +++ b/tools/virsh-nodedev.c
> @@ -1113,6 +1113,61 @@ cmdNodeDeviceDefine(vshControl *ctl, const vshCmd *cmd G_GNUC_UNUSED)
>  }
>
>
> +/*
> + * "nodedev-start" command
> + */
> +static const vshCmdInfo info_node_device_start[] = {
> +    {.name = "help",
> +     .data = N_("Start a previously defined inactive node device")
> +    },
> +    {.name = "desc",
> +     .data = N_("Starts the configuration for an inactive node device")

How about
"Takes an inactive node device configuration and creates a device based on it"

would that work as a description?

Regards,
Erik


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]