[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt PATCH 8/9] qemu: Allow migration over UNIX socket



On Tue, Aug 25, 2020 at 07:47:14AM +0200, Martin Kletzander wrote:
> This allows:
> 
>  a) migration without access to network
> 
>  b) complete control of the migration stream
> 
>  c) easy migration between containerised libvirt daemons on the same host
> 
> Resolves: https://bugzilla.redhat.com/1638889
> 
> Signed-off-by: Martin Kletzander <mkletzan redhat com>
> ---
>  docs/manpages/virsh.rst   |  17 ++++-
>  docs/migration.html.in    |  33 ++++++++++
>  src/qemu/qemu_migration.c | 128 +++++++++++++++++++++++++++-----------


> +virsh migrate web1 [--p2p] --copy-storage-all 'qemu+unix:///system?socket=/tmp/migdir/test-sock-driver' 'unix://?socket=/tmp/migdir/test-sock-qemu' [--listen-address /tmp/migdir/test-sock-qemu] --disks-socket /tmp/migdir/test-sock-nbd
> +    </pre>

Why  unix://?socket=/tmp/migdir/test-sock-qemu  instead of the more obvious
unix:///tmp/migdir/test-sock-qemu  ?  It feels like ?socket is just
reinventing the URI path component.

That ?socket syntax makes sense for the libvirtd URIs, because we use
the path component to identify the libvirtd instance.

For the migration URI nothing is using the path component, so we should
use that for the UNIX path.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]