[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt PATCH 2/3] AUTHORS: Some small tweaks



On Tue, 2020-08-25 at 18:47 +0200, Ján Tomko wrote:
> On a Tuesday in 2020, Andrea Bolognani wrote:
> > Signed-off-by: Andrea Bolognani <abologna redhat com>
> 
> Missing commit message.

I figured this kind of changes didn't require much in the way of
explanation.

> > -The libvirt project was initiated by:
> > +The libvirt project was started by:
> 
> What's wrong with initiated?

It seems unnecessarily formal.

> > -The primary maintainers and people with commit access rights:
> > +Primary maintainers and people with commit access rights are:
> 
> What is the benefit of adding the word 'are'?

Two of the existing lists take the following form:

  "The libvirt project was initiated by X"
  "Patches have also been contributed by X"

This change makes the remaining two lists similar:

  "Primary maintainers are X"
  "Previous maintainers are X"

It's ultimately mostly down to preferences... If you don't like the
changes in this patch I will happily drop it, the one I really care
about is the first one in the series.

> > -The libvirt logo was designed by Diana Fong
> > +The libvirt logo was designed by Diana Fong.
> 
> This hunk looks good.

\o/

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]