[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH V4 1/3] Xen: Add writeFiltering option for PCI devices



On Mon, Aug 24, 2020 at 08:26:55AM -0600, Jim Fehlig wrote:
> By default Xen only allows guests to write "known safe" values into PCI
> configuration space, yet many devices require writes to other areas of
> the configuration space in order to operate properly. To allow writing
> any values Xen supports the 'permissive' setting, see xl.cfg(5) man page.
> 
> This change models Xen's permissive setting by adding a writeFiltering
> attribute on the <source> element of a PCI hostdev. When writeFiltering
> is set to 'no', the Xen permissive setting will be enabled and guests
> will be able to write any values into the device's configuration space.
> The permissive setting remains disabled in the absense of the
> writeFiltering attribute, of if it is explicitly set to 'yes'.
> 
> Signed-off-by: Jim Fehlig <jfehlig suse com>
> Signed-off-by: Simon Gaiser <simon invisiblethingslab com>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek invisiblethingslab com>
> ---
>  docs/formatdomain.rst                          |  7 ++++++-
>  docs/schemas/domaincommon.rng                  |  5 +++++
>  src/conf/domain_conf.c                         | 14 ++++++++++++++
>  src/conf/domain_conf.h                         |  1 +
>  src/libxl/libxl_conf.c                         |  1 +
>  src/qemu/qemu_validate.c                       |  7 +++++++
>  tests/libxlxml2domconfigdata/moredevs-hvm.json |  6 ++++++
>  tests/libxlxml2domconfigdata/moredevs-hvm.xml  |  5 +++++
>  8 files changed, 45 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange redhat com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]