[libvirt] [PATCH] qemu: Warn of restore with managed save being risky
Daniel Henrique Barboza
danielhb413 at gmail.com
Thu Jan 2 14:54:23 UTC 2020
On 1/2/20 11:36 AM, Michael Weiser wrote:
> Hello Daniel,
>
> On Thu, Jan 02, 2020 at 09:58:19AM -0300, Daniel Henrique Barboza wrote:
>
[...]
> I'd rather not reference virsh command options in the error message as
> it would be highly confusing in any other context. For example, python
> clients get the error message wrapped in an exception, augmented already
> by a prefix telling them they need to force the operation:
Good point.
>
> Traceback (most recent call last):
> File "/usr/share/virt-manager/virtManager/asyncjob.py", line 75, in cb_wrapper
> callback(asyncjob, *args, **kwargs)
> File "/usr/share/virt-manager/virtManager/asyncjob.py", line 111, in tmpcb
> callback(*args, **kwargs)
> File "/usr/share/virt-manager/virtManager/object/libvirtobject.py", line 66, in newfn
> ret = fn(self, *args, **kwargs)
> File "/usr/share/virt-manager/virtManager/object/domain.py", line 1055, in revert_to_snapshot
> self._backend.revertToSnapshot(snap.get_backend())
> File "/usr/lib64/python3.6/site-packages/libvirt.py", line 2088, in revertToSnapshot
> if ret == -1: raise libvirtError ('virDomainRevertToSnapshot() failed', dom=self)
> libvirt.libvirtError: revert requires force: revert to snapshot while
> there is a managed saved state will cause corruption when run, remove
> saved state first
>
> The same is actually the case for virsh already:
>
> virsh # snapshot-revert debian --snapshotname snapshot1
> error: revert requires force: revert to snapshot while there is a
> managed saved state will cause corruption when run, remove saved state
> first
>
> virsh #
>
> We could of course reword to better take context and prefix into
> account, e.g.:
Since there is already a "revert requires force" prefix in both python and
virsh error messages, changing the error message of this v1 becomes more of
a wording/flavor issue.
>
> error: revert requires force: Removal of existing managed saved state
> strongly recommended to avoid corruption
I prefer this wording though :)
Thanks,
DHB
More information about the libvir-list
mailing list