[libvirt] [jenkins-ci PATCH v2] guests: add more detailed docs on deploying FreeBSD

[Andrea Bolognani]

On Wed, 2020-01-08 at 11:19 +0000, Daniel P. Berrangé wrote:
[...]
> +  $ sudo virt-install \
> +      --import \
> +      --name libvirt-freebsd-$MAJOR \
> +      --vcpus 2 \
> +      --graphics vnc \
> +      --noautoconsole \
> +      --console pty \
> +      --sound none \
> +      --rng device=/dev/urandom,model=virtio \
> +      --memory 2048 \
> +      --os-variant freebsd$MAJOR.0 \
> +      --disk /var/lib/libvirt/images/libvirt-freebsd-$MAJOR.qcow2

This doesn't necessarily need sudo: the other instructions kind of
assume your regular user has access to qemu:///system, by being a
member of the "libvirt" group for example. We should clarify that
in the "Host setup" section (as a separate patch of course).

> +The default qcow2 images are sized too small to be usable. To enlarge
> +them do
> +
> + $ sudo virsh blockresize libvirt-freebsd-$MAJOR \
> +     /var/lib/libvirt/images/libvirt-freebsd-$MAJOR.qcow2 20G

This doesn't need sudo either, and also please s/20/15/ as mentioned
during the first round of reviews.

> +Then inside the guest, as root, enlarge the 3rd partition & filesystem
> +to consume all new space:
> +
> + # gpart resize -i 3 vtbd0
> + # service growfs onestart

Please make sure this section containing commands, as well as the
ones above, are indented with 4 spaces so that they show up in a
monospace font when the document is rendered as HTML.

With all of the above addressed,

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization