[libvirt] libvirt 6.0.0 make check-TESTS fails "FAIL: test-ptsname_r"

[Satheesh Rajendran]

On Mon, Jan 13, 2020 at 04:13:43PM -0300, Daniel Henrique Barboza wrote:
> Satheesh,
> 
> Did you update the .gnulib submodule as well? I am asking this because commit
> 
Hi Daniel,

1. Thanks for reverting back, I guess libvirt repository yet to update submodule 
with those commit, it is still pointing to 7d069378921bfa0d7c7198ea177aac0a2440016f 
a little older.

2. Even if I update .gnulib submodule to point to origin/master, it gets revert back to
old commit while running autogen.sh

# git submodule foreach git status
Entering '.gnulib'
On branch master
Your branch is up to date with 'origin/master'.
...

# ../libvirt/autogen.sh -prefix=/usr/share/avocado-plugins-vt/bin
Updating submodules...
Submodule path '.gnulib': checked out '7d069378921bfa0d7c7198ea177aac0a2440016f'
Running autoreconf...
...

# git submodule foreach git status
Entering '.gnulib'
HEAD detached at 7d0693789
nothing to commit, working tree clean
...

3. Then pointing gnulib explicitly with latest commits with --no-git worked
#  GNULIB_SRCDIR=/home/sath/gnulib  ../libvirt/autogen.sh --no-git
..

But it would be good to have libvirt submodule updated with latest 
gnulib commit to getrid of this issue.

Thanks!

Regards,
-Satheesh.


> 
> commit b7d7afe10ddf599452bd80b8a840c830cd474b09
> Author: Bruno Haible <bruno at clisp.org>
> Date:   Sun Jan 5 09:13:25 2020 +0100
> 
>     tests: Avoid GCC over-optimization caused by _GL_ARG_NONNULL attributes.
>     Reported by Jim Meyering in
>     <https://lists.gnu.org/archive/html/bug-gnulib/2020-01/msg00040.html>.
> 
> 
> Is putting run restrictions in the test failing for you. In a quick glance, it
> looks like this commit should avoid the problem.
> 
> You can update the .gnulib module by going into the .gnulib dir, then
> 'git checkout master' and 'git pull'.
> 
> 
> Thanks,
> 
> 
> DHB
> 
> 
> 
> On 1/13/20 1:00 PM, Satheesh Rajendran wrote:
> > Hi,
> > 
> > libvirt 6.0.0 (commit:bfd5f69d6038daeac03d2684fcd98aeee4ef1e24), "make rpm" fails at
> > make check-TESTS
> > 
> > ...
> > ..
> > PASS: test-memchr
> > PASS: test-send
> > ../../../build-aux/test-driver: line 107: 453114 Aborted                 (core dumped) "$@" > $log_file 2>&1
> > FAIL: test-ptsname_r
> > PASS: test-setsockopt
> > PASS: test-sigaction
> > PASS: test-signal-h
> > ...
> > -------
> > # cat /root/rpmbuild/BUILD/libvirt-6.0.0/ppc64le-redhat-linux-gnu/gnulib/tests/test-suite.log
> > ================================================
> >     libvirt 6.0.0: gnulib/tests/test-suite.log
> > ================================================
> > 
> > # TOTAL: 149
> > # PASS:  148
> > # SKIP:  0
> > # XFAIL: 0
> > # FAIL:  1
> > # XPASS: 0
> > # ERROR: 0
> > 
> > .. contents:: :depth: 2
> > 
> > FAIL: test-ptsname_r
> > ====================
> > 
> > ../../../gnulib/tests/test-ptsname_r.c:89: assertion 'result == EINVAL' failed
> > FAIL test-ptsname_r (exit status: 134)
> > 
> > --------
> > 
> > 
> > Env:
> > HW: Power8
> > ArcH: ppc64le
> > OS: Fedora 31
> > GCC: 9.2.1 20190827 (Red Hat 9.2.1-1)
> > Glibc: glibc-2.30-8.fc31.ppc64le
> > 
> > 
> > Gdb output:
> > 
> > # gdb /root/rpmbuild/BUILD/libvirt-6.0.0/ppc64le-redhat-linux-gnu/gnulib/tests/test-ptsname_r -c core.test-ptsname_r.0.1a9e4ce7d7ec4d7e81e295f7f67c7029.317503.1578922893000000000000
> > GNU gdb (GDB) Fedora 8.3.50.20190824-26.fc31
> > ..
> > ..
> > Reading symbols from /root/rpmbuild/BUILD/libvirt-6.0.0/ppc64le-redhat-linux-gnu/gnulib/tests/test-ptsname_r...
> > [New LWP 317503]
> > [Thread debugging using libthread_db enabled]
> > Using host libthread_db library "/lib64/libthread_db.so.1".
> > Core was generated by `./test-ptsname_r '.
> > Program terminated with signal SIGABRT, Aborted.
> > #0  0x00007fffac447358 in __libc_signal_restore_set (set=0x7fffefdc3078) at ../sysdeps/unix/sysv/linux/internal-signals.h:84
> > 84	  return INTERNAL_SYSCALL (rt_sigprocmask, err, 4, SIG_SETMASK, set, NULL,
> > (gdb) start
> > Temporary breakpoint 1 at 0x11d850c88: file ../../../gnulib/tests/test-ptsname_r.c, line 94.
> > Starting program: /root/rpmbuild/BUILD/libvirt-6.0.0/ppc64le-redhat-linux-gnu/gnulib/tests/test-ptsname_r
> > [Thread debugging using libthread_db enabled]
> > Using host libthread_db library "/lib64/libthread_db.so.1".
> > Temporary breakpoint 1, 0x0000000100000c88 in main () at ../../../gnulib/tests/test-ptsname_r.c:94
> > 94	{
> > (gdb) c
> > Continuing.
> > ../../../gnulib/tests/test-ptsname_r.c:89: assertion 'result == EINVAL' failed
> > Program received signal SIGABRT, Aborted.
> > 0x00007ffff7d57358 in __libc_signal_restore_set (set=0x7fffffffe438) at ../sysdeps/unix/sysv/linux/internal-signals.h:84
> > 84	  return INTERNAL_SYSCALL (rt_sigprocmask, err, 4, SIG_SETMASK, set, NULL,
> > (gdb) print result
> > $1 = '\000' <repeats 113 times>
> > (gdb)
> > 
> > Any help would be appreciated, Thanks in advance.
> > 
> > Regards,
> > -Satheesh.
> > 
> > 
> > --
> > libvir-list mailing list
> > libvir-list at redhat.com
> > https://www.redhat.com/mailman/listinfo/libvir-list
> >