[libvirt-tck PATCH 2/2] nwfilter: Make use of the SSH pubkey auth rather than password-based auth

Erik Skultety eskultet at redhat.com
Tue Jan 21 17:05:53 UTC 2020


On Tue, Jan 21, 2020 at 05:02:09PM +0000, Daniel P. Berrangé wrote:
> On Tue, Jan 21, 2020 at 05:47:17PM +0100, Erik Skultety wrote:
> > Not only have SSH keys been a good practice for a while, it fixes our
> > SSH connections to the f31 test vm.
> >
> > Signed-off-by: Erik Skultety <eskultet at redhat.com>
> > ---
> >  scripts/nwfilter/210-no-mac-spoofing.t  | 2 +-
> >  scripts/nwfilter/220-no-ip-spoofing.t   | 2 +-
> >  scripts/nwfilter/230-no-mac-broadcast.t | 2 +-
> >  scripts/nwfilter/240-no-arp-spoofing.t  | 2 +-
> >  4 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/scripts/nwfilter/210-no-mac-spoofing.t b/scripts/nwfilter/210-no-mac-spoofing.t
> > index 95f003a..9798c4f 100644
> > --- a/scripts/nwfilter/210-no-mac-spoofing.t
> > +++ b/scripts/nwfilter/210-no-mac-spoofing.t
> > @@ -95,7 +95,7 @@ ok($ping =~ "10 received", "ping $guestip test");
> >  diag "ssh'ing into $guestip";
> >  my $ssh = Net::OpenSSH->new($guestip,
> >                              user => "root",
> > -                            password => $tck->root_password(),
> > +			    key_path => $tck->ssh_key_path($tck->scratch_dir()),
>
> Tabs in indent here & the other four places.

Shoot, I created the patches in a VM where I don't have all my editor settings,
sorry, will change.

Thanks,
Erik




More information about the libvir-list mailing list