[PATCH v2 0/9] virsh: secret: Improve handling of secret value

Peter Krempa pkrempa at redhat.com
Fri Jan 24 16:08:32 UTC 2020


Improve handling of secrets for security.

'secret-passwd' command was dropped in favor of '--interactive' and few
other changes requested at review.

Peter Krempa (9):
  virsh: Work around virSecretFree quirks
  virsh: secret: Refactor cleanup in cmdSecretSetValue
  virsh: secret: Refactor cleanup in cmdSecretGetValue
  virsh: secret: Add --plain flag for secret-get-value
  virsh: secret: Add --file 'filename' support for secret-set-value
  virsh: secret: Print warning that passing secret on command-line is
    insecure
  virsh: secret: Add --plain switch for secret-set-value
  tools: virsh: Add --interactive flag for secret-set-value command
  docs: secret: Unify and sanitize examples on how to set secret value

 build-aux/syntax-check.mk      |   2 +-
 docs/formatsecret.html.in      |  88 +++++++++++++--------
 docs/manpages/virsh.rst        |  20 ++++-
 tools/virsh-completer-secret.c |   3 +-
 tools/virsh-secret.c           | 140 ++++++++++++++++++++++++---------
 tools/virsh-util.c             |  11 +++
 tools/virsh-util.h             |   5 ++
 7 files changed, 195 insertions(+), 74 deletions(-)

-- 
2.24.1




More information about the libvir-list mailing list