[libvirt PATCH v2 01/56] tests: stop setting $SHELL env variable

Daniel P. Berrangé berrange at redhat.com
Tue Jan 28 13:10:42 UTC 2020


None of the tests appear to reference a SHELL env variable
explicitly and they all succeeed when it is not set. This
eliminates the only use of the gnulib posix-shell module.

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
---
 tests/Makefile.am | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tests/Makefile.am b/tests/Makefile.am
index f957c7d1ba..19705c6b76 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -16,8 +16,6 @@
 ## License along with this library.  If not, see
 ## <http://www.gnu.org/licenses/>.
 
-SHELL = $(PREFERABLY_POSIX_SHELL)
-
 AM_CPPFLAGS = \
 	-I$(top_builddir) -I$(top_srcdir) \
 	-I$(top_builddir)/gnulib/lib -I$(top_srcdir)/gnulib/lib \
@@ -484,7 +482,6 @@ TESTS_ENVIRONMENT = \
   abs_top_srcdir="$(abs_top_srcdir)" \
   abs_builddir="$(abs_builddir)" \
   abs_srcdir="$(abs_srcdir)" \
-  SHELL="$(SHELL)" \
   LIBVIRT_AUTOSTART=0 \
   LC_ALL=C \
   VIR_TEST_EXPENSIVE=$(VIR_TEST_EXPENSIVE) \
-- 
2.24.1




More information about the libvir-list mailing list