[libvirt PATCH 21/31] src: remote: Makefile: drop CFLAGS and LDFLAGS duplication

[Ján Tomko]

On a Thursday in 2020, Pavel Hrdina wrote:
>Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
>---
> src/remote/Makefile.inc.am | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
>diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am
>index 8a40c96563c..893d6894e2f 100644
>--- a/src/remote/Makefile.inc.am
>+++ b/src/remote/Makefile.inc.am
>@@ -35,16 +35,13 @@ REMOTE_DAEMON_SOURCES = \
> 	$(NULL)
>
> REMOTE_DAEMON_CFLAGS = \
>-	$(LIBXML_CFLAGS) \
>-	$(GLIB_CFLAGS) \
>+	$(AM_CFLAGS) \
> 	$(GNUTLS_CFLAGS) \
> 	$(SASL_CFLAGS) \
> 	$(XDR_CFLAGS) \
> 	$(DBUS_CFLAGS) \
> 	$(LIBNL_CFLAGS) \
>-	$(WARN_CFLAGS) \
> 	$(PIE_CFLAGS) \
>-	$(COVERAGE_CFLAGS) \
> 	-I$(srcdir)/access \
> 	-I$(builddir)/access \
> 	-I$(srcdir)/conf \

No practical change in this hunk.

>@@ -54,11 +51,9 @@ REMOTE_DAEMON_CFLAGS = \
> 	$(NULL)
>
> REMOTE_DAEMON_LD_FLAGS = \
>-	$(RELRO_LDFLAGS) \
>+	$(AM_LDFLAGS) \
> 	$(PIE_LDFLAGS) \
>-	$(NO_INDIRECT_LDFLAGS) \
> 	$(NO_UNDEFINED_LDFLAGS) \
>-	$(COVERAGE_LDFLAGS) \
> 	$(NULL)


AM_LDFLAGS also contains $(DRIVER_MODULES_LDFLAGS)
i.e. -export-dynamic

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200709/00caec90/attachment-0001.sig>