[PATCH 7/7] qemu_security: Complete renaming of virSecurityManagerSetAllLabel() argument

Erik Skultety eskultet at redhat.com
Fri Jul 10 10:44:56 UTC 2020


On Wed, Jul 01, 2020 at 06:15:07PM +0200, Michal Privoznik wrote:
> Just like in the previous commit, the stdin_path argument of
> virSecurityManagerSetAllLabel() is renamed to incomingPath.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_security.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/qemu/qemu_security.c b/src/qemu/qemu_security.c
> index 34cfcd3256..621523f086 100644
> --- a/src/qemu/qemu_security.c
> +++ b/src/qemu/qemu_security.c
> @@ -32,7 +32,7 @@ VIR_LOG_INIT("qemu.qemu_security");
>  int
>  qemuSecuritySetAllLabel(virQEMUDriverPtr driver,
>                          virDomainObjPtr vm,
> -                        const char *stdin_path,
> +                        const char *incomingPath,
>                          bool migrated)

The same change should be performed in qemu_security.h

I also think since all of the stdin_path occurrences are security related, you
can squash 6 and 7 together. While doing that you might as well toss in an
identical patch for da863c2ad15 which also missed the same change in the header
file.

Erik




More information about the libvir-list mailing list