[PATCH] storage: fix vstorage backend build

[Nikolay Shirokovskiy]

On 13.07.2020 09:57, Nikolay Shirokovskiy wrote:
> 
> 
> On 10.07.2020 21:17, Andrea Bolognani wrote:
>> On Fri, 2020-07-10 at 18:26 +0100, Daniel P. Berrangé wrote:
>>> On Fri, Jul 10, 2020 at 06:40:07PM +0200, Andrea Bolognani wrote:
>>>> That failed with
>>>>
>>>>   Error: Package: vstorage-libs-shared-7.10.1.5-1.vz7.x86_64 (vz)
>>>>              Requires: libjson-c.so.2(libjson-c.so.2)(64bit)
>>>>
>>>> which is surprising because I have the json-c package installed.
>>>> I think that's caused by a bug in your spec file - the name of the
>>>> library should not appear in parentheses - but I can't seem to find
>>>> the source package for vstorage-client under
>>>>
>>>>   http://repo.virtuozzo.com/vz/releases/7.0/source/SRPMS/
>>>
>>> Yes, this dependancy is clearly broken, whcih is the reason why
>>> we're not using the URL you show above, and instead using the older
>>> release at:
>>>
>>>   https://download.openvz.org/virtuozzo/releases/openvz-7.0.11-235/x86_64/os/
>>>
>>> this URL is the last one that doesn't have the broken dependancies.
>>
>> Note that we're not just talking about different releases available
>> from the same repository, but about two completely different
>> repositories: the one we're using is under
>>
>>   https://download.openvz.org/virtuozzo/releases/
>>
>> whereas the one Nikolay pointed to for vstorage package is under
>>
>>   http://repo.virtuozzo.com/vz/releases/
>>
>> If you look at the list of releases, you'll see that the versions are
>> similar but always a bit different: I couldn't find a single release
>> which is available on both sites.
>>
>> If you look at the list of packages through the provided "repoview"
>> files, the releases from the second repository contain many more:
>> additional categories include things like "Readykernel", Virtuozzo
>> High Availability" and, most interesting to us, "Virtuozzo Storage".
>>
>> As mentioned in my previous message, some of these packages appear to
>> be released not under the (L)GPL but under a "Virtuozzo" license that
>> I haven't been able to find anywhere, and I'm not entirely sure is
>> actually open source.
>>
> 
> We have Virtuozzo product and part of it is available as open source
> from openvz.org repo. Virtuozzo Storage is not open source but it
> can be used with very limited storage size without license keys.
> I guess you would want to read license anyway before using Virtuozzo
> Storage packages in CI but I'm going to remove these packages
> requirements anyway as I wrote in reply to Andrea's message.
> 

After giving it more thought I think it is useful to have vstorage
m4 script as it is. It is useful to detect vstorage-mount binary
path at build time. Although Virtuozzo Storage is not open source
and can not be build for distributions with different binary paths
by community it is a part of different Virtuozzo products and
theoretically speaking the path can be changed from product to product.
So it is useful to have path not hardcoded and not detected at runtime.

Before we fix our repos please take a look at Virtuozzo license at [1]
(note there is different tabs and EULA tab).

[1] https://www.virtuozzo.com/legal.html