[libvirt PATCH 0/2] tests: Don't assume IPv4 connectivity is available

[Michal Privoznik]

On 7/14/20 10:32 PM, Andrea Bolognani wrote:
> I started looking into this after seeing
> 
>    FAIL: virnetsockettest
>    ======================
> 
>    TEST: virnetsockettest
>     1) Socket TCP/IPv4 Accept                       ... libvirt: XML-RPC error : Unable to resolve address '127.0.0.1' service '5672': Address family for hostname not supported
>    FAILED

> 
> during a Debian package build.
> 
> Full log:
> 
>    https://buildd.debian.org/status/fetch.php?pkg=libvirt&arch=armel&ver=6.4.0-2&stamp=1594738948&raw=0
> 
> Just a few days ago, this issue was discussed in
> 
>    https://lists.debian.org/debian-devel/2020/07/msg00070.html
> 
> and libvirt was mentioned explicitly as a package that could be
> affected by it.

Indeed. I'm able to reproduce and working on a fix as we speak.
The problem is that our test assumes that if there is an interface with 
IPv4 address (as returned by getifaddrs()) then getaddrinfo() of an IPv4 
address succeeds. We've seen with IPv6 that it is not true - that's why 
virNetSocketCheckProtocols() does explicit getaddrinfo() for an IPv6 
address. We need to do the same for IPv4.

Anyway, for these two:

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal