[libvirt PATCH 114/351] meson: add default_editor build option

[Pavel Hrdina]

On Wed, Jul 22, 2020 at 04:44:32PM +0200, Peter Krempa wrote:
> On Thu, Jul 16, 2020 at 11:55:50 +0200, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> > ---
> >  configure.ac              |  3 ---
> >  m4/virt-default-editor.m4 | 32 --------------------------------
> >  meson.build               |  3 +++
> >  meson_options.txt         |  1 +
> >  4 files changed, 4 insertions(+), 35 deletions(-)
> >  delete mode 100644 m4/virt-default-editor.m4
> 
> I'd also argue for removing all of this and plainly erroring out in
> virsh if 'EDITOR' env variable is not set.

I'm not so sure about this. It will probably make no difference for
users but I would like to see opinion of others.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200722/886f57c6/attachment-0001.sig>