[PATCH 19/32] qemu: checkpoint: Don't merge checkpoints during deletion

Eric Blake eblake at redhat.com
Thu Jun 18 16:30:03 UTC 2020


On 6/15/20 12:10 PM, Peter Krempa wrote:
> Now that we've switched to the simple handling, the first thing that can
> be massively simplified is checkpoint deletion. We now need to only go
> through the backing chain and find the appropriately named bitmaps and
> delete them, no complex lookups or merging.
> 
> Note that compared to other functions this deletes the bitmap in all
> layers compared to others where we expect only exactly 1 bitmap of a
> name in the backing chain to prevent potential problems.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   src/qemu/qemu_checkpoint.c | 153 ++++++-------------------------------
>   src/qemu/qemu_checkpoint.h |   1 -
>   tests/qemublocktest.c      |   7 +-
>   3 files changed, 25 insertions(+), 136 deletions(-)
> 

No kidding about the simplification.

Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list