[PATCH v2 0/2] vmx: make 'fileName' optional for CD-ROMs

Pino Toscano ptoscano at redhat.com
Wed Mar 18 09:51:06 UTC 2020


v1 is:
https://www.redhat.com/archives/libvir-list/2020-March/msg00616.html

Changes from v1:
- added a patch to shortcut few checks
- use NULLSTR
- handle floppies (poor guys)

Pino Toscano (2):
  vmx: shortcut earlier few 'ignore' cases in virVMXParseDisk()
  vmx: make 'fileName' optional for CD-ROMs

 src/vmx/vmx.c                                 | 67 ++++++++++---------
 .../vmx2xmldata/vmx2xml-cdrom-ide-empty-2.vmx |  4 ++
 .../vmx2xmldata/vmx2xml-cdrom-ide-empty-2.xml | 23 +++++++
 tests/vmx2xmltest.c                           |  1 +
 4 files changed, 62 insertions(+), 33 deletions(-)
 create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-ide-empty-2.vmx
 create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-ide-empty-2.xml

-- 
2.25.1




More information about the libvir-list mailing list