[PATCH 2/2] virStorageEncryptionSecretCopy: Properly copy internals

Ján Tomko jtomko at redhat.com
Thu Mar 19 17:14:15 UTC 2020


On a Thursday in 2020, Peter Krempa wrote:
>virStorageEncryptionSecretPtr may have a string inside it, thus we must
>copy the string too. Use virSecretLookupDefCopy to do that.
>
>Likely caused by 756b46ddd24.

Please remove the period from the end.

Also, at the times of that commit, memcpy was sufficient:
struct _virStorageEncryptionSecret {
     int type; /* virStorageEncryptionSecretType */
     unsigned char uuid[VIR_UUID_BUFLEN];
};

So this actually fixes commit 47e88b33b which switched to using
virSecretLookupDef.

>
>https://bugzilla.redhat.com/show_bug.cgi?id=1814923
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/util/virstorageencryption.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200319/525117a8/attachment-0001.sig>


More information about the libvir-list mailing list