[libvirt PATCH 1/4] qemu: virtiofs: kill the whole process group when stopping

Ján Tomko jtomko at redhat.com
Mon Mar 23 16:10:34 UTC 2020


After startup, virtiofds forks itself to drop its privileges.
Kill the whole process group instead of just the parent.

https://bugzilla.redhat.com/show_bug.cgi?id=1808697

Signed-off-by: Ján Tomko <jtomko at redhat.com>
Reported-by: Andrew Jones <drjones at redhat.com>
---
 src/qemu/qemu_virtiofs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_virtiofs.c b/src/qemu/qemu_virtiofs.c
index d579ce1d33..d6159206eb 100644
--- a/src/qemu/qemu_virtiofs.c
+++ b/src/qemu/qemu_virtiofs.c
@@ -285,7 +285,7 @@ qemuVirtioFSStop(virQEMUDriverPtr driver G_GNUC_UNUSED,
 
     rc = virPidFileReadPathIfAlive(pidfile, &pid, NULL);
     if (rc >= 0 && pid != (pid_t) -1)
-        virProcessKillPainfully(pid, true);
+        virProcessKillPainfully(-pid, true);
 
     if (unlink(pidfile) < 0 &&
         errno != ENOENT) {
-- 
2.25.1




More information about the libvir-list mailing list