[PATCH v2 01/11] tests: Fix virQEMUDriverConfigNew() calling with respect to @root

[Daniel P. Berrangé]

On Thu, Mar 26, 2020 at 04:15:05PM +0100, Michal Privoznik wrote:
> The virQEMUDriverConfigNew() accepts path to root directory for
> embed mode as an argument. If the argument is not NULL it uses
> the passed value as prefix for some internal paths (e.g.
> cfg->libDir). If it is NULL though, it looks if the other
> argument, @privileged is true or false and generates internal
> paths accordingly. But when calling the function from the test
> suite, instead of passing NULL for @root, an empty string is
> passed. Fortunately, this doesn't create a problem because in
> both problematic cases the generated paths are "fixed" to point
> somewhere into build dir or the code which is tested doesn't
> access them.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> Reviewed-by: Andrea Bolognani <abologna at redhat.com>
> Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
> ---
>  tests/domaincapstest.c | 2 +-
>  tests/testutilsqemu.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|