[libvirt PATCH 2/2] CONTRIBUTING: Include note about build system tools

Daniel P. Berrangé berrange at redhat.com
Mon May 4 16:51:25 UTC 2020


On Mon, Apr 27, 2020 at 02:01:44PM +0200, Andrea Bolognani wrote:
> On Mon, 2020-04-27 at 12:19 +0100, Daniel P. Berrangé wrote:
> > On Mon, Apr 27, 2020 at 01:15:08PM +0200, Andrea Bolognani wrote:
> > > I expect most people doing development work on libvirt are using
> > > Fedora rather than RHEL, and I really don't want this document to
> > > become too verbose or duplicate too much information that's already
> > > available elsewhere... If we can cover ~90% of potential users with
> > > just a few commands, I think that's preferable.
> > 
> > Just listing the extra packages is simpler than the group name.
> > 
> >    dnf install gcc make automake libtool autoconf rpm-build
> 
> Point taken, the list is short and unlikely to change much.
> 
> Can I have your Reviewed-by for the series if I squash your version
> in?

Yep, with that change added

  Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

And this is fine for freeze.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list