[PATCH v2 2/3] qemuBuildNumaArgStr: Switch order of if() and for()

Ján Tomko jtomko at redhat.com
Fri May 15 15:14:38 UTC 2020


On a Thursday in 2020, Michal Privoznik wrote:
>When building -numa command line there is a for() loop that
>builds '-numa memdev=' for each guest NUMA node. And also
>records in a local variable whether any of memory-object-*
>backends must be used to satisfy desired config. Well, instead of
>checking in each iteration whether corresponding capabilities are
>set, we can do swap if() and for() and check only once.
>
>Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1783355
>

"Fixes" is confusing here, since this commit is a no-op.

>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/qemu/qemu_command.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200515/d51abb8d/attachment-0001.sig>


More information about the libvir-list mailing list