[PATCH v2 3/3] qemuBuildNumaArgStr: Use modern -numa memdev= if old -numa mem= is unsupported

[Ján Tomko]

On a Thursday in 2020, Michal Privoznik wrote:
>In previous commit we started tracking whether QEMU supports
>'-numa mem='. This is tied to the machine type because migration
>from '-numa mem=' to '-numa memdev' is impossible (or vice
>versa). But since it's tied to a machine type (where migration
>from one to another is also unsupported) we can allow QEMU to get
>rid of the deprecated command line.
>

(At least) this commit should have the bugzilla link.

>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/qemu/qemu_command.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
>diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
>index cf6c48d233..19c45cb4e3 100644
>--- a/src/qemu/qemu_command.c
>+++ b/src/qemu/qemu_command.c
>@@ -7038,6 +7038,11 @@ qemuBuildNumaArgStr(virQEMUDriverConfigPtr cfg,
>     if (!virDomainNumatuneNodesetIsAvailable(def->numa, priv->autoNodeset))
>         goto cleanup;
>
>+    if (!virQEMUCapsGetMachineNumaMemSupported(qemuCaps,
>+                                               def->virtType,
>+                                               def->os.machine))
>+        needBackend = true;
>+
>     if (VIR_ALLOC_N(nodeBackends, ncells) < 0)
>         goto cleanup;
>
>@@ -7055,6 +7060,10 @@ qemuBuildNumaArgStr(virQEMUDriverConfigPtr cfg,
>             if (rc == 0)
>                 needBackend = true;
>         }
>+    } else if (needBackend) {
>+        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
>+                       _("numa not supported"));

s/numa/NUMA/

Also, can we be more helpful, e.g.

"NUMA without specified memory backing is not supported with this QEMU
binary"

>+        goto cleanup;
>     }

Either way:

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200515/16976d9c/attachment-0001.sig>