[PATCH 05/21] qemuBuildChannelChrDeviceStr: Remove formatting of properties for -netdev

Eric Blake eblake at redhat.com
Fri May 15 22:03:18 UTC 2020


On 5/15/20 10:27 AM, Peter Krempa wrote:
> The output of the function is fed as argument to '-device' command line
> argument or 'device_add' monitor command except for 'guestfwd' channels
> where it needs to be fed to -netdev/netdev_add. This is confusing and
> error prone. Split it up since the caller needs to know which
> command/option to use anyways, so the caller can call the appropriate
> function without any magic.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   src/qemu/qemu_command.c | 36 ++++++++++++++++++++----------------
>   src/qemu/qemu_command.h |  3 +++
>   src/qemu/qemu_hotplug.c | 18 +++++++++++++-----
>   3 files changed, 36 insertions(+), 21 deletions(-)
Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list