[libvirt PATCH 1/6] qemu: stop checking virObjectUnref return value

Eric Blake eblake at redhat.com
Tue May 19 19:30:28 UTC 2020


On 5/19/20 12:41 PM, Daniel P. Berrangé wrote:
> Some, but not all, of the monitor event handlers check
> the virObjectUnref return value to see if the domain
> was disposed.
> 
> It should not be possible for this to happen, since
> the functional ready holds a lock on the domain and

s/functional ready/function already/ (not everyday that a misplaced 
space still results in two valid words which might still legitimately 
appear adjacent in some other sentence...)

> has only just acquired an extra reference on the
> domain a few lines earlier.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>   src/qemu/qemu_process.c | 30 ++++++++++++------------------
>   1 file changed, 12 insertions(+), 18 deletions(-)
> 
-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list