[libvirt PATCH 4/4] scripts: emit raw enum value in API build description
Daniel P. Berrangé
berrange at redhat.com
Thu May 21 12:47:36 UTC 2020
On Thu, May 21, 2020 at 02:43:10PM +0200, Michal Privoznik wrote:
> On 5/19/20 3:01 PM, Daniel P. Berrangé wrote:
> > Currently the value for an enum is only emitted if it is a plain
> > string. If the enum is an integer or hex value, or a complex code block,
> > it is omitted from the API build. This fixes that by emitting the raw
> > value if no string value is present.
> >
> > With this change:
> >
> > <macro name='LIBVIR_CHECK_VERSION'
> > file='libvirt-common'
> > params='major,minor,micro'>
> > <macro name='LIBVIR_VERSION_NUMBER'
> > file='libvirt-common'>
> > <macro name='VIR_COPY_CPUMAP'
> > file='libvirt-domain'
> > params='cpumaps,maplen,vcpu,cpumap'>
> > ...snip...
> >
> > <macro name='LIBVIR_CHECK_VERSION'
> > file='libvirt-common'
> > params='major,minor,micro'
> > raw='((major) * 1000000 + (minor) * 1000 + (micro) <= LIBVIR_VERSION_NUMBER)'>
> > <macro name='LIBVIR_VERSION_NUMBER'
> > file='libvirt-common'
> > raw='6004000'>
> > <macro name='VIR_COPY_CPUMAP'
> > file='libvirt-domain'
> > params='cpumaps,maplen,vcpu,cpumap'
> > raw='memcpy(cpumap, VIR_GET_CPUMAP(cpumaps, maplen, vcpu), maplen)'>
> > ...snip...
> >
> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> > ---
> > scripts/apibuild.py | 10 ++++++++--
> > 1 file changed, 8 insertions(+), 2 deletions(-)
>
> I'm seeing some weird errors after I apply this one, like:
Sigh, the patch i sent was missing the "escape()" call to
escape <>"
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
More information about the libvir-list
mailing list