[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] rpm: Fix conditional for defining %_vpath_builddir for RHEL <= 7



On Sat, Aug 29, 2020 at 20:09:18 -0400, Neal Gompa wrote:
> The conditional was incorrectly overriding %_vpath_builddir when
> %rhel is not defined, which led to surprising behavior when the
> global %_vpath_builddir path is set on Fedora already.
> 
> Signed-off-by: Neal Gompa <ngompa13 gmail com>
> ---
>  libvirt.spec.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index bb74443484..4b9e04ae61 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -32,7 +32,7 @@
>  %endif
>  
>  # On RHEL 7 and older macro _vpath_builddir is not defined.
> -%if 0%{?rhel} <= 7
> +%if 0%{?rhel} && 0%{?rhel} <= 7
>      %define _vpath_builddir %{_target_platform}
>  %endif
>  

Reviewed-by: Jiri Denemark <jdenemar redhat com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]