[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH v2 7/9] peer2peer migration: allow connecting to local sockets



On Tue, Sep 01, 2020 at 16:36:58 +0200, Martin Kletzander wrote:
> Local socket connections were outright disabled because there was no "server"
> part in the URI.  However, given how requirements and usage scenarios are
> evolving, some management apps might need the source libvirt daemon to connect
> to the destination daemon over a UNIX socket for peer2peer migration.  Since we
> cannot know where the socket leads (whether the same daemon or not) let's decide
> that based on whether the socket path is non-standard, or rather explicitly
> specified in the URI.  Checking non-standard path would require to ask the
> daemon for configuration and the only misuse that it would prevent would be a
> pretty weird one.  And that's not worth it.  The assumption is that whenever
> someone uses explicit UNIX socket paths in the URI for migration they better
> know what they are doing.
> 
> Partially resolves: https://bugzilla.redhat.com/1638889
> 
> Signed-off-by: Martin Kletzander <mkletzan redhat com>
> ---
>  docs/manpages/virsh.rst    |  9 +++++++++
>  src/libvirt-domain.c       |  8 +++++++-
>  src/remote/remote_driver.c |  8 ++++++--
>  src/util/viruri.c          | 30 ++++++++++++++++++++++++++++++
>  src/util/viruri.h          |  2 ++
>  tests/virmigtest.c         |  2 +-
>  6 files changed, 55 insertions(+), 4 deletions(-)

Reviewed-by: Jiri Denemark <jdenemar redhat com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]