[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Fix linkage to libutil and libkvm on FreeBSD 11



On a Friday in 2020, Daniel P. Berrangé wrote:
We are currently adding -lutil and -lkvm to the linker using the
add_project_link_arguments method. On FreeBSD 11.4, this results in
build errors because the args appear too early in the command line.

We need to pass the libraries as dependencies so that they get placed
at the same point in the linker args as other dependencies.

Signed-off-by: Daniel P. Berrangé <berrange redhat com>
---
meson.build           | 16 +++++++---------
src/bhyve/meson.build | 15 +++++++++++----
src/util/meson.build  | 26 +++++++++++++++++---------
3 files changed, 35 insertions(+), 22 deletions(-)

Using the CI patch I posted earlier to add FreeBSD 11:

 https://gitlab.com/berrange/libvirt/-/pipelines/185834799



Reviewed-by: Ján Tomko <jtomko redhat com>

And it looks like a fun and safe change to push on a Friday afternoon.

Jano

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]