[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH REBASE 1/7] qemuBuildMemoryBackendProps: Move @prealloc setting to backend agnostic part



On a Tuesday in 2020, Michal Privoznik wrote:
All three memory backends (-file, -ram and -memfd) have .prealloc
attribute. Since we are setting it only for -file, the
corresponding code lives only under if() that handles that
specific backend. But in near future we will want to set the
attribute for other backends too. Therefore, move the
corresponding code outside of the if().

This causes some .argv files to be changed, but the only change
happening there is move of the attribute (best viewed with:
'git show --color-words=.').

Signed-off-by: Michal Privoznik <mprivozn redhat com>
---
src/qemu/qemu_command.c                       | 11 +++----
.../qemuxml2argvdata/hugepages-memaccess.args | 30 +++++++++----------
.../hugepages-memaccess2.args                 | 12 ++++----
.../hugepages-numa-nodeset-part.args          |  5 ++--
.../hugepages-numa-nodeset.args               | 20 ++++++++-----
.../hugepages-nvdimm.x86_64-latest.args       |  9 +++---
tests/qemuxml2argvdata/hugepages-shared.args  | 24 +++++++--------
.../memory-hotplug-dimm-addr.args             |  6 ++--
.../qemuxml2argvdata/memory-hotplug-dimm.args |  6 ++--
...y-hotplug-nvdimm-access.x86_64-latest.args |  4 +--
...ry-hotplug-nvdimm-align.x86_64-latest.args |  4 +--
...ry-hotplug-nvdimm-label.x86_64-latest.args |  4 +--
...ory-hotplug-nvdimm-pmem.x86_64-latest.args |  4 +--
...ory-hotplug-nvdimm-ppc64.ppc64-latest.args |  2 +-
...hotplug-nvdimm-readonly.x86_64-latest.args |  4 +--
.../memory-hotplug-nvdimm.x86_64-latest.args  |  2 +-
.../qemuxml2argvdata/pages-dimm-discard.args  |  4 +--
tests/qemuxml2argvdata/user-aliases.args      | 16 +++++-----
...vhost-user-fs-hugepages.x86_64-latest.args |  5 ++--
19 files changed, 90 insertions(+), 82 deletions(-)


Reviewed-by: Ján Tomko <jtomko redhat com>

Jano

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]