[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt PATCH 2/2] meson: Add tests_timeout build option



On Wed, 2020-09-09 at 15:19 +0100, Daniel P. Berrangé wrote:
> On Wed, Sep 09, 2020 at 04:17:21PM +0200, Andrea Bolognani wrote:
> > On Wed, 2020-09-09 at 15:01 +0100, Daniel P. Berrangé wrote:
> > > It appears that 'ninja test' is just a dumb shim to invoke
> > > 'meson test'.  Given that using meson test directly looks
> > > much saner as you get the full range of functionality
> > > available.
> > 
> > I think it's the other way around, isn't it? That is, 'meson test'
> > is a wrapper for 'ninja test' which adds a bunch of functionality on
> > top.
> 
> That's not what the build.ninja says:
> 
> build meson-test: CUSTOM_COMMAND all PHONY
>  COMMAND = /usr/bin/meson test --no-rebuild --print-errorlogs
>  DESC = Running$ all$ tests.
>  pool = console
> 
> build test: phony meson-test
> 
> There's nothing else in the build.ninja that refers to execution
> of tests - it merely builds them.

So it is! And same for 'ninja install', as it turns out.

Thanks for correcting my understanding :)

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]