[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] meson: src: Fix DESTDIR handling while creating dirs



On 09.09.20 16:38, Erik Skultety wrote:
> On Mon, Sep 07, 2020 at 11:25:34PM +0200, Jan Kiszka wrote:
>> From: Jan Kiszka <jan kiszka siemens com>
>>
>> If the target path contains a link with an absolute path (e.g.
>> /var/run -> /run), makedirs will target the wrong location. Resolve the
>> path first, then append DESTDIR again if needed.
>
> Can you elaborate on this? os.makedirs should follow the symlinks before
> actually creating the directory hierarchy, so I'm failing to see the problem
> this patch is trying to address.
>

mkdir -p /my/destdir/var /my/destdir/run
ln -s /run /my/destdir/var/run
meson build --prefix=/usr
DESTDIR=/my/destdir ninja -C build install

-> PermissionError: [Errno 13] Permission denied:
'/my/destdir/var/run/libvirt'

Jan



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]