[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH v5 1/2] conf: add 'isa' controller type



On Sat, Aug 01, 2020 at 10:16:56AM +0400, Roman Bogorodskiy wrote:
> Introduce 'isa' controller type. In domain XML it looks this way:
> 
>     ...
>     <controller type='isa' index='0'>
>       <address type='pci' domain='0x0000' bus='0x00' slot='0x01'
>                function='0x0'/>
>     </controller>
>     ...
> 
> Currently, this is needed for the bhyve driver to allow choosing a
> specific PCI address for that. In bhyve, this controller is used to
> attach serial ports and a boot ROM.
> 
> Signed-off-by: Roman Bogorodskiy <bogorodskiy gmail com>
> ---
>  docs/formatdomain.html.in      | 6 +++---
>  docs/schemas/domaincommon.rng  | 6 ++++++
>  src/conf/domain_conf.c         | 9 +++++++++
>  src/conf/domain_conf.h         | 8 ++++++++
>  src/qemu/qemu_command.c        | 1 +
>  src/qemu/qemu_domain.c         | 1 +
>  src/qemu/qemu_domain_address.c | 1 +
>  src/qemu/qemu_validate.c       | 1 +
>  src/vbox/vbox_common.c         | 1 +
>  9 files changed, 31 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange redhat com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]